Closed
Bug 765905
Opened 12 years ago
Closed 6 years ago
Improve the avmshell projector
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: alexmac, Unassigned)
Details
Attachments
(2 files)
10.50 KB,
patch
|
stan
:
review+
|
Details | Diff | Splinter Review |
4.35 KB,
patch
|
stan
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.56 Safari/536.5 Steps to reproduce: This patch improves the avmshell projector support so that VM arguments can be baked into the projector along with the swf/abc. This makes it easier to distribute avmshell projectors as standalone applications that behave indistinguishably from their native counterparts. I've also included a small utility "projectormake.as" which can be used to package a swf/abc and an avmshell into a projector
Reporter | ||
Comment 1•12 years ago
|
||
Updated•12 years ago
|
Attachment #634164 -
Attachment is patch: true
Updated•12 years ago
|
Attachment #634165 -
Attachment is patch: true
Comment 2•12 years ago
|
||
Comment on attachment 634165 [details] [diff] [review] as3 utility for creating projectors No newline at end of file, nice to fix. Trivial style things (just sayin')" - No types? Awwww! Well, whatever. - "littleEndian" versus Endian.LITTLE_ENDIAN?
Attachment #634165 -
Flags: review?(stan)
Comment 3•12 years ago
|
||
Comment on attachment 634165 [details] [diff] [review] as3 utility for creating projectors No action required on previous comments.
Attachment #634165 -
Flags: review?(stan) → review+
Comment 4•12 years ago
|
||
Comment on attachment 634164 [details] [diff] [review] projector-improvements.patch I wonder if it would be useful to recognize both old-style "headers" (trailers, really) and new-style headers so that people can continue to package projectors however they used to. (Which is what, by the way?)
Attachment #634164 -
Flags: review?(stan)
Comment 5•12 years ago
|
||
Comment on attachment 634164 [details] [diff] [review] projector-improvements.patch Assuming there's no need to support old-style projector construction, it looks fine.
Attachment #634164 -
Flags: review?(stan) → review+
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•