765905 - Improve the avmshell projector

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Alex Macdonald]

Attachment: projector-improvements.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.56 Safari/536.5

Steps to reproduce:

This patch improves the avmshell projector support so that VM arguments can be baked into the projector along with the swf/abc. This makes it easier to distribute avmshell projectors as standalone applications that behave indistinguishably from their native counterparts.

I've also included a small utility "projectormake.as" which can be used to package a swf/abc and an avmshell into a projector

Comment 1

[Alex Macdonald]

Attachment: as3 utility for creating projectors

Comment 2

[Stan Switzer]

Comment on attachment 634165 [details] [diff] [review]
as3 utility for creating projectors

No newline at end of file, nice to fix.

Trivial style things (just sayin')"

 - No types? Awwww! Well, whatever.

 - "littleEndian" versus Endian.LITTLE_ENDIAN?

Comment 3

[Stan Switzer]

Comment on attachment 634165 [details] [diff] [review]
as3 utility for creating projectors

No action required on previous comments.

Comment 4

[Stan Switzer]

Comment on attachment 634164 [details] [diff] [review]
projector-improvements.patch

I wonder if it would be useful to recognize both old-style "headers" (trailers, really) and new-style headers so that people can continue to package projectors however they used to. (Which is what, by the way?)

Comment 5

[Stan Switzer]

Comment on attachment 634164 [details] [diff] [review]
projector-improvements.patch

Assuming there's no need to support old-style projector construction, it looks fine.